![]() There's no shortage of people on github who wish to seem helpful (in the eyes of potential employers) who may come at you with all kinds of minor corrections. Plus those are just my first impressions, there could be some good reasons for why it is the way it is. ![]() Not big deals but I'm just saying there is always room for improvement. There is also a lot of Hungarian notation used. My feedback is there could be better commenting, there are a lot of constants used without being declared as constants, unused variables, and seemingly unneeded temporary variables that really don't serve to clarify anything, as well as values that should remain constant being passed around to functions. I recognise some of it from Alex's original plugin. ![]() In any case I took a closer look at just one of the projects. I had a little trouble understanding the folder structure in the source files - I think not everything corresponds to a finished functionality? I wonder if someone can help you better organize this to avoid dealing with copy-pasting redundant code? I can't. The real "documentation" for me is being able to see the code, and I'm somewhat familiar already with Alex's old code as well as a similar plugin for GIMP. I'm a little tainted because I've been through the de-honeycombing process several times, and quite recently too, so all of the information that *I* need is fresh in my head. ![]() Your documentation is extensive, which is all anyone can hope for - and it is certainly more info than anyone has gotten in one place before.
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |